SystemVerilog: Parsing and type checking for queue types #967

kroening · 2025-02-05T14:52:53Z

This adds parsing and type checking for 1800-2017 7.10 queues.

tautschnig · 2025-02-06T13:07:04Z

Is the change to the cbmc submodule intentional?

kroening · 2025-02-06T14:35:26Z

No, will fix.

This adds parsing and type checking for 1800-2017 7.10 queues.

kroening · 2025-02-06T16:34:27Z

Fixed

tautschnig · 2025-02-07T09:39:07Z

src/verilog/expr2verilog.cpp

+    std::string dest = "queue of ";
+    dest += convert(to_type_with_subtype(type).subtype());


Is it intentional that this will not produce valid SystemVerilog?

Yes; since you need a declarator, there's not parse-able SystemVerilog just for the type.

kroening added the Verilog label Feb 5, 2025

kroening force-pushed the verilog-queue branch 2 times, most recently from 844da97 to dda8e5a Compare February 5, 2025 15:09

kroening marked this pull request as ready for review February 5, 2025 15:53

SystemVerilog: Parsing and type checking for queue types

77644f4

This adds parsing and type checking for 1800-2017 7.10 queues.

kroening force-pushed the verilog-queue branch from dda8e5a to 77644f4 Compare February 6, 2025 16:34

tautschnig reviewed Feb 7, 2025

View reviewed changes

tautschnig approved these changes Feb 9, 2025

View reviewed changes

tautschnig merged commit c2c8b0d into main Feb 9, 2025
9 checks passed

tautschnig deleted the verilog-queue branch February 9, 2025 07:39

Provide feedback

		std::string dest = "queue of ";
		dest += convert(to_type_with_subtype(type).subtype());